Project

General

Profile

Actions
Copy link

Bug #14715

closed

libsa: Fix a bug in nvlist creation

Added by Toomas Soome 3 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
bootloader
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
2165

Description

Patch picked from FreeBSD:

https://reviews.freebsd.org/D35254

When adding an entry to an nvlist, the data buffer might need to be resized. When this happens, the XDR encoder's notion of the buffer size also needs to be updated, otherwise the operation may erroneously fail.

Testing done: build/install/boot.

Actions
Copy link
 #1

Updated by Electric Monk 3 months ago

  • Gerrit CR set to 2165
Actions
Copy link
 #2

Updated by Yuri Pankov 3 months ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Electric Monk 3 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 43075873f664db76209f1fdf87cb3961a113bfaf

commit  43075873f664db76209f1fdf87cb3961a113bfaf
Author: Mark Johnston <markj@FreeBSD.org>
Date:   2022-05-27T19:51:15.000Z

    14715 libsa: Fix a bug in nvlist creation
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Yuri Pankov <ypankov@tintri.com>
    Reviewed by: Gordon Ross <Gordon.W.Ross@gmail.com>
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Approved by: Dan McDonald <danmcd@mnx.io>

Actions
Copy link

Also available in: Atom PDF