clean malloc/free shims from bhyve
The kernel potion of bhyve uses some shims for
free() from when it was ported from FreeBSD.
It would be nice to update those to use kmem_alloc/kmem_free directly, where possible, and more constrained shims when requirements are more strict (such as the page tables for VT-d).
Updated by Patrick Mooney about 2 months ago
I tested this on both AMD and Intel hardware.
The test suite still passes:
Results Summary PASS 21 Running Time: 00:00:14 Percent passed: 100.0% Log directory: /var/tmp/test_results/20220609T164939 ... Results Summary PASS 21 Running Time: 00:00:15 Percent passed: 100.0% Log directory: /var/tmp/test_results/20220609T165100
I proceeded through the normal battery of guest OS smoke tests. All booted and ran successfully.
With all of those tests done on DEBUG bits with kmem debugging enabled, I then initiated dumps on both machines and check the resulting cores with
::kmem_verify, which both reported clean (modulo the expected noise).
Updated by Electric Monk about 2 months ago
- Status changed from New to Closed
- % Done changed from 0 to 100
commit 8130f8e19e97c2d371c7b8894112a375409fe34a Author: Patrick Mooney <firstname.lastname@example.org> Date: 2022-06-10T03:22:27.000Z 14731 clean malloc/free shims from bhyve Reviewed by: Andy Fiddaman <email@example.com> Reviewed by: Dan Cross <firstname.lastname@example.org> Approved by: Gordon Ross <email@example.com>