Project

General

Profile

Actions

Bug #14776

closed

pcieadm typos bytes to byes

Added by Robert Mustacchi about 1 month ago. Updated 23 days ago.

Status:
Closed
Priority:
Normal
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

In several places in the pcieadm config space related decoding logic, we typo bytes as byes. Fix all these.

Actions #1

Updated by Electric Monk about 1 month ago

  • Gerrit CR set to 2210
Actions #2

Updated by Robert Mustacchi 30 days ago

It was hard to test this one directly as the devices we have don't advertise the specific max sizes that had the particular typos; however, in addition to normal use and verifying that I ran through the util-tests which has the pcieadm parts of the test suite which all passed:

rm@romulus ~ $ pfexec /opt/util-tests/tests/pcieadm-priv
successfully listed devices
TEST PASSED: show-devs 0/0/0
BDF     TYPE           DRIVER         DEVICE
0/0/0   PCI            amdzen_stub0   Starship/Matisse Root Complex
pcieadm: filter '9000/9000/9000' did not match any devices
TEST PASSED: show-devs 0/0/0 9000/9000/9000
TEST PASSED: show-cfgspace -d 0/0/0
TEST PASSED: save-cfgspace -d 0/0/0
TEST PASSED: show-devs amdzen_stub0
BDF     TYPE           DRIVER         DEVICE
0/0/0   PCI            amdzen_stub0   Starship/Matisse Root Complex
pcieadm: filter '9000/9000/9000' did not match any devices
TEST PASSED: show-devs amdzen_stub0 9000/9000/9000
TEST PASSED: show-cfgspace -d amdzen_stub0
TEST PASSED: save-cfgspace -d amdzen_stub0
TEST PASSED: show-devs /pci@0,0/pci1458,1000@0
BDF     TYPE           DRIVER         DEVICE
0/0/0   PCI            amdzen_stub0   Starship/Matisse Root Complex
pcieadm: filter '9000/9000/9000' did not match any devices
TEST PASSED: show-devs /pci@0,0/pci1458,1000@0 9000/9000/9000
TEST PASSED: show-cfgspace -d /pci@0,0/pci1458,1000@0
TEST PASSED: save-cfgspace -d /pci@0,0/pci1458,1000@0
pcieadm: filter '/enoent' did not match any devices
TEST PASSED: show-devs /enoent
TEST PASSED: save-cfgspace -a
All tests passed successfully!
rm@romulus ~ $ pfexec /opt/util-tests/tests/pcieadmtest
TEST PASSED: invalid arguments 
TEST PASSED: invalid arguments -d
TEST PASSED: invalid arguments foobar
TEST PASSED: invalid arguments save-cfgspace
TEST PASSED: invalid arguments save-cfgspace -a
TEST PASSED: invalid arguments save-cfgspace -d
TEST PASSED: invalid arguments save-cfgspace -d final
TEST PASSED: invalid arguments save-cfgspace -a -d fantasy
TEST PASSED: invalid arguments show-devs -h
TEST PASSED: invalid arguments show-devs -p
TEST PASSED: invalid arguments show-devs -s -o
TEST PASSED: invalid arguments show-cfgspace
TEST PASSED: invalid arguments show-cfgspace -d -H
TEST PASSED: invalid arguments show-cfgspace -d
TEST PASSED: invalid arguments show-cfgspace -f
TEST PASSED: invalid arguments show-cfgspace -h
TEST PASSED: invalid arguments show-cfgspace -L
TEST PASSED: invalid arguments show-cfgspace -L -n -f /opt/util-tests/tests/pci/igb.pci
TEST PASSED: invalid arguments show-cfgspace -L -p -f /opt/util-tests/tests/pci/igb.pci
TEST PASSED: invalid arguments show-cfgspace -p -f /opt/util-tests/tests/pci/igb.pci
TEST PASSED: invalid arguments show-cfgspace -o foo -f /opt/util-tests/tests/pci/igb.pci
TEST PASSED: invalid arguments show-cfgspace -L -o foo -f /opt/util-tests/tests/pci/igb.pci
TEST PASSED: show-cfgspace -f /dev/stdin header0.vendor header0.device
TEST PASSED: show-cfgspace -L -f /dev/stdin header0.vendor header0.device
TEST PASSED: show-cfgspace -n -f /dev/stdin header0.vendor header0.device
TEST PASSED: show-cfgspace -L -H -f /dev/stdin header0.vendor header0.device
TEST PASSED: show-cfgspace -f /dev/stdin ltr
TEST PASSED: show-cfgspace -p -o short,value -f /dev/stdin ltr
TEST PASSED: show-cfgspace -p -o short,value -f /dev/stdin header0.vendor header0.device
TEST PASSED: show-cfgspace -f /dev/stdin ht
TEST PASSED: show-cfgspace -f /dev/stdin ht.msi
TEST PASSED: show-cfgspace -f /dev/stdin ht.msi.command
TEST PASSED: show-cfgspace -p -o value,short -f /dev/stdin ht
TEST PASSED: show-cfgspace -p -o value,short -f /dev/stdin ht.msi
TEST PASSED: show-cfgspace -p -o value,short -f /dev/stdin ht.msi.command
TEST PASSED: show-cfgspace -f /dev/stdin pcie.linksts atelier
TEST PASSED: show-cfgspace -p -o short,value -f /dev/stdin pcie.linksts atelier
All tests passed successfully!
Actions #3

Updated by Electric Monk 23 days ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 1bcd6a1a4eeaf2fd7a90ce8b8cebd4f34baf049f

commit  1bcd6a1a4eeaf2fd7a90ce8b8cebd4f34baf049f
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2022-07-20T00:20:40.000Z

    14776 pcieadm typos bytes to byes
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Approved by: Garrett D'Amore <garrett@damore.org>

Actions

Also available in: Atom PDF