vioscsi timeout list insertion error
This came up during the review of pvscsi
When we add to the list of expiration commands, if we didn't find a command, or we didn't find one that expires sooner, than we should use list_insert_head -- right now the code erroneously uses list_insert_tail.
This is unlikely to cause a problem, (some expirations may take longer than they should, but that would only be for commands that are timing out which is not normal) but we should fix it.
Updated by Garrett D'Amore about 1 month ago
I’ve tested this for basic functionality on a KVM CentOS system. However, the conditions where this would manifest incorrect behavior are difficult to simulate and observe, so for now my testing is basic functionality testing. The incorrect insertion order was noted in code review of another driver, and I recalled that I also got it wrong here, so am fixing it.
Updated by Electric Monk about 1 month ago
- Status changed from Pending RTI to Closed
- % Done changed from 90 to 100
commit 06d7f587729595e6085b8b33777ff119f3a9b767 Author: Garrett D'Amore <email@example.com> Date: 2022-07-11T02:48:39.000Z 14785 vioscsi timeout list insertion error Reviewed by: Joshua M. Clulow <firstname.lastname@example.org> Reviewed by: Andy Fiddaman <email@example.com> Approved by: Richard Lowe <firstname.lastname@example.org>