Project

General

Profile

Actions

Bug #14785

closed

vioscsi timeout list insertion error

Added by Garrett D'Amore about 1 month ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

This came up during the review of pvscsi

When we add to the list of expiration commands, if we didn't find a command, or we didn't find one that expires sooner, than we should use list_insert_head -- right now the code erroneously uses list_insert_tail.

This is unlikely to cause a problem, (some expirations may take longer than they should, but that would only be for commands that are timing out which is not normal) but we should fix it.

Actions #1

Updated by Electric Monk about 1 month ago

  • Gerrit CR set to 2226
Actions #2

Updated by Garrett D'Amore about 1 month ago

Testing:

I’ve tested this for basic functionality on a KVM CentOS system. However, the conditions where this would manifest incorrect behavior are difficult to simulate and observe, so for now my testing is basic functionality testing. The incorrect insertion order was noted in code review of another driver, and I recalled that I also got it wrong here, so am fixing it.

Actions #3

Updated by Garrett D'Amore about 1 month ago

  • Status changed from In Progress to Pending RTI
  • % Done changed from 0 to 90
Actions #4

Updated by Electric Monk about 1 month ago

  • Status changed from Pending RTI to Closed
  • % Done changed from 90 to 100

git commit 06d7f587729595e6085b8b33777ff119f3a9b767

commit  06d7f587729595e6085b8b33777ff119f3a9b767
Author: Garrett D'Amore <garrett@damore.org>
Date:   2022-07-11T02:48:39.000Z

    14785 vioscsi timeout list insertion error
    Reviewed by: Joshua M. Clulow <josh@sysmgr.org>
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions

Also available in: Atom PDF