Project

General

Profile

Actions

Bug #14799

closed

Sonoma support (A3500 legacy FC) handling obsolete

Added by Garrett D'Amore 5 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

sd.c haČ™ some special workarounds for Sonoma. The drivers to support Sonoma were only available on SPARC, and utilized the sf/pf/socal stack.

It's time to pay off that particular bit of technical debt.

Specifically there is special handling for ILLEGAL REQUEST, sense code 94, qualifier 0x01. This was never documented anywhere, and is not part of any special handling.

Actions #1

Updated by Garrett D'Amore 5 months ago

  • Subject changed from Sonoma handling (A1000, A3500 legacy FC) handling can be removed to Sonoma support (A1000, A3500 legacy FC) handling obsolete
Actions #2

Updated by Electric Monk 5 months ago

  • Gerrit CR set to 2227
Actions #3

Updated by Garrett D'Amore 5 months ago

  • Status changed from New to In Progress
Actions #4

Updated by Garrett D'Amore 5 months ago

  • Subject changed from Sonoma support (A1000, A3500 legacy FC) handling obsolete to Sonoma support (A3500 legacy FC) handling obsolete
Actions #5

Updated by Garrett D'Amore 4 months ago

As this is removing handling for a device family we don't have, there is not a lot to test here.

I did test booting with this change using a root filesystem built on top of this driver (in OmniOS), and did some basic operations (like diskinfo, etc.) I also verified that I was running the actual modified binary using mdb to verify that the symbol sd_is_lsi is not present anymore.

Actions #6

Updated by Electric Monk 4 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit 0a9766a583bfa5050067949d9ee2ad7bb0dadaa9

commit  0a9766a583bfa5050067949d9ee2ad7bb0dadaa9
Author: Garrett D'Amore <garrett@damore.org>
Date:   2022-08-01T16:30:08.000Z

    14799 Sonoma support (A3500 legacy FC) handling obsolete
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Peter Tribble <peter.tribble@gmail.com>
    Approved by: Dan McDonald <danmcd@mnx.io>

Actions

Also available in: Atom PDF