Project

General

Profile

Actions

Feature #14820

closed

Want SMBIOS 3.6 Support

Added by Robert Mustacchi 3 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

With SMBIOS 3.6 now out, we should update libsmbios to account for it. Note, this adds an additional processor extension for Loongson. At this time we are not implementing the detailed processor information (Type 44) extension.


Related issues

Related to illumos gate - Bug #14872: smbios_info_processor forgot ext clock speedClosedRobert Mustacchi

Actions
Actions #1

Updated by Robert Mustacchi 2 months ago

  • Related to Bug #14872: smbios_info_processor forgot ext clock speed added
Actions #2

Updated by Electric Monk 2 months ago

  • Gerrit CR set to 2279
Actions #3

Updated by Robert Mustacchi 2 months ago

To test this I ran through the full SMBIOS test suite, which passed. I used the test suite -d feature to test the smbios(8) output against the new fields. I also looked at regressions between smbios(8) output on an AMD Rome system .The only changes were the expected ones for the processor type due to what was added.

Here's us processing the test table with the new field, seeing us print the value. Note these values are weird, but they match the test suite, which is what we were going for:

$ smbios ./SMBIOS\ 3.6\ processor.smbios 
ID    SIZE TYPE
1     90   SMB_TYPE_PROCESSOR (type 4) (processor)

  Manufacturer: Harrow
  Version: Nona
  Serial Number: Alecto
  Asset Tag: Matthias
  Location Tag: Gideon
  Part Number: Ortus

  Family: 513 (RISC-V RV64)
  CPUID: 0x9099090
  Type: 3 (central processor)
  Socket Upgrade: 55 (socket SP3)
  Socket Status: Populated
  Processor Status: 1 (enabled)
  Supported Voltages: 1.1V
  Core Count: 369
  Cores Enabled: 1815
  Thread Count: 21573
  Processor Characteristics: 0x24
        SMB_PRC_64BIT (64-bit capable)
        SMB_PRC_NX (execution protection)
  External Clock Speed: 4660MHz
  Maximum Speed: 22136MHz
  Current Speed: 12816MHz
  L1 Cache Handle: 4554
  L2 Cache Handle: 4810
  L3 Cache Handle: 5066
  Threads Enabled: 8754

Here's the test suite output:

TEST PASSED: bad library version
TEST PASSED: bad library version (zeros)
TEST PASSED: smbios_info_* with bad id
TEST PASSED: smbios string functions
TEST PASSED: slot 3.2
TEST PASSED: slot 3.4 without peers
TEST PASSED: slot 3.4 with peers
TEST PASSED: slot 3.5 against 3.4 lib
TEST PASSED: slot 3.5
TEST PASSED: memory device 3.2 % 3.2
TEST PASSED: memory device 3.2 % 3.3
TEST PASSED: memory device 3.3
TEST PASSED: memory device 3.3
TEST PASSED: processor additional information - amd64
TEST PASSED: processor additional information - riscv
TEST PASSED: processor additional information - bad table length 1
TEST PASSED: processor additional information - bad table length 2
TEST PASSED: processor additional information - bad table length 3
TEST PASSED: processor additional information - bad table length 4
TEST PASSED: processor additional information - bad type
TEST PASSED: string property - bad table length 1
TEST PASSED: string property - bad table length 2
TEST PASSED: string property - bad type
TEST PASSED: string property - basic
TEST PASSED: string property - bad string
TEST PASSED: firmware inventory - bad base length
TEST PASSED: firmware inventory - bad comp length
TEST PASSED: firmware inventory - bad type
TEST PASSED: firmware inventory - no components
TEST PASSED: firmware inventory - components
TEST PASSED: chassis - bad length (2.4 table)
TEST PASSED: chassis - bad length (latest version)
TEST PASSED: chassis - bad length, expect sku
TEST PASSED: chassis - basic 2.4 version
TEST PASSED: chassis - sku, but no components
TEST PASSED: chassis - 2.4 version with comps
TEST PASSED: chassis - sku + comps
TEST PASSED: SMBIOS 2.5 processor
TEST PASSED: SMBIOS 3.6 processor
TEST PASSED: SMBIOS 3.6 processor, 2.5 client
All tests passed successfully
Actions #4

Updated by Electric Monk 2 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 1d1fc316c9e8072a7e63a5b1218bab66b9a66b66

commit  1d1fc316c9e8072a7e63a5b1218bab66b9a66b66
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2022-08-07T00:00:13.000Z

    14820 Want SMBIOS 3.6 Support
    14872 smbios_info_processor forgot ext clock speed
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Rich Lowe <richlowe@richlowe.net>

Actions

Also available in: Atom PDF