Project

General

Profile

Actions

Bug #14828

closed

remove SPARC FMA support

Added by Garrett D'Amore almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Category:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

There are a bunch of bits of FMA to support SPARC hardware. We can remove it.

Note that inside some of the modules, some of the code is structured with #ifdef's that suggest sparc vs. other architectures. We should probably leave that alone for now, until such time as we have at least one other architecture -- on the basis that the code there may be useful to folks doing further architecture ports. Once such code for an alternate architecture exists, then it can be cleaned of sparc references.

FMA is one of the more complex bits of user space, so cleaning it up is a nice step in the right direction.

Actions #1

Updated by Electric Monk almost 2 years ago

  • Gerrit CR set to 2252
Actions #2

Updated by Garrett D'Amore almost 2 years ago

Testing is largely mechanical confirmation that this does not meaningfully impact deliverables, apart from some expected things that are not used on i386 and were removed:

gdamore@rts-build-01:~/ws/illumos/sparc-fma% pkgrepo diff -s packages/i386/nightly-nd/repo.redist -s ../14799-sonoma/packages/i386/nightly-nd/repo.redist

The table below shows the number of packages [total distinct versions]
by publisher in the specified repositories.

  • Repo1: /devp02/gdamore/illumos/sparc-fma/packages/i386/nightly-nd/repo.redist/
  • Repo2: /devp02/gdamore/illumos/14799-sonoma/packages/i386/nightly-nd/repo.redist/

----------------------+------------+---------+------------+ | Publisher | Repo1 only | Repo2 only | In both | Total |
----------------------+------------+---------+------------+ | on-nightly | 0 [539] | 0 [539] | 539 [0] | 539 [1078] |
----------------------+------------+---------+------------+

There are no source code changes at all in this PR, only removal of non-source files (and in particular some message catalogs).

Using the same script I used to compare changes to package contents revealed no changes to what is delivered on the system:

gdamore@rts-build-01:~/ws/illumos% ksh /tmp/compare_repos.ksh 14799-sonoma sparc-fma
Workspace 1: 14799-sonoma/packages/i386/nightly
Workspace 2: sparc-fma/packages/i386/nightly
done

An onu and boot of a system with this change was uneventful.

Actions #3

Updated by Electric Monk almost 2 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 5c0b3261bd16d5eb356ffc864b6eab76c2e760e5

commit  5c0b3261bd16d5eb356ffc864b6eab76c2e760e5
Author: Garrett D'Amore <garrett@damore.org>
Date:   2022-08-02T00:48:35.000Z

    14828 remove SPARC FMA support
    Reviewed by: Peter Tribble <peter.tribble@gmail.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Dan McDonald <danmcd@mnx.io>

Actions

Also available in: Atom PDF