Project

General

Profile

Actions

Bug #14846

closed

loader: console setup is still broken

Added by Toomas Soome 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

I got two notifications about issues. First one was from Yuri, who found that vmware vm without serial ports defined, was spamming loader menu screen. Second one was from Dominic, who noticed that one system did only set console to ttyb and not "text,ttyb".

Investigating the issue, I got some changes which do simplify the code and make it more robust.

cons_change():
return list of console devices from cons_change().
we do walk the list of proposed consoles in cons_change(),
lets build final activated consoles list there.

cons_probe():
stop calling c_probe() twice.
clean up and simplify prefconsole handling.

cons_set():
use console name list from cons_change()


Related issues

Related to illumos gate - Bug #14585: loader: should preserve order of console device listClosedToomas Soome

Actions
Actions #1

Updated by Toomas Soome 5 months ago

  • Related to Bug #14585: loader: should preserve order of console device list added
Actions #2

Updated by Electric Monk 5 months ago

  • Gerrit CR set to 2247
Actions #3

Updated by Dominik Hassler 5 months ago

I can confirm that with this change in place I get output at the VGA console again by default.

Actions #4

Updated by Electric Monk 5 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit f3ba9b4e08f448ddcb00b37383e05dae8544e31e

commit  f3ba9b4e08f448ddcb00b37383e05dae8544e31e
Author: Toomas Soome <tsoome@me.com>
Date:   2022-07-26T21:14:46.000Z

    14846 loader: console setup is still broken
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Approved by: Dan McDonald <danmcd@mnx.io>

Actions

Also available in: Atom PDF