Project

General

Profile

Actions

Bug #14853

closed

overlay_setprop_vnetid bungles OVERLAY_F_MDDROP

Added by Robert Mustacchi 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

While reviewing #14827 I noticed that overlay_setprop_vnetid was the other place that we manipulate OVERLAY_F_MDDROP. While we set the OVERLAY_F_MDDROP on entry before we do the mux manipulation, we don't actually clear it. In fact, we do something somewhat worse. We not only forget to set it, but we also clear out the OVERLAY_F_IN_MUX. While looking at this there are other things that may seem suspect, at least we know this part is wrong. In particular, we don't really want to clear out the OVERLAY_F_IN_MUX as we remain in it. However, but not clearing OVERLAY_F_MDDROP then we'll never really get traffic moving again.


Related issues

Related to illumos gate - Bug #14827: overlay_m_stop() blows verify in race with overlay_target_inject()ClosedDan McDonald

Actions
Actions #1

Updated by Dan McDonald 4 months ago

  • Related to Bug #14827: overlay_m_stop() blows verify in race with overlay_target_inject() added
Actions #2

Updated by Electric Monk 4 months ago

  • Gerrit CR set to 2251
Actions #3

Updated by Dan McDonald 4 months ago

See #14827 for any test notes.

Actions #4

Updated by Electric Monk 4 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit bdb5139270356ff627abb9467f2b4fc8db3fb81d

commit  bdb5139270356ff627abb9467f2b4fc8db3fb81d
Author: Dan McDonald <danmcd@mnx.io>
Date:   2022-08-04T19:07:27.000Z

    14827 overlay_m_stop() blows verify in race with overlay_target_inject()
    14853 overlay_setprop_vnetid bungles OVERLAY_F_MDDROP
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Approved by: Gordon Ross <Gordon.W.Ross@gmail.com>

Actions

Also available in: Atom PDF