Project

General

Profile

Actions

Bug #14859

closed

locale command Makefiles could be simpler

Added by Garrett D'Amore 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

The usr/src/cmd/locale tree has a a far more complex Makefile structure than needed.

We only need to deliver 64-bit binaries, and we can do so without subdirectories, or special rules for catalog generation (we can use Makefile.master's default rules).

Actions #1

Updated by Garrett D'Amore 4 months ago

This pattern is reproduced in many places, but let's start with this one first.

Actions #2

Updated by Electric Monk 4 months ago

  • Gerrit CR set to 2266
Actions #3

Updated by Garrett D'Amore 4 months ago

This also avoids some duplicate compilation -- we were building both 32- and 64-bit binaries, but only shipping one of them (which was determined solely based on build order.)

Actions #4

Updated by Garrett D'Amore 4 months ago

Testing notes:

Verified the following:

  • The built SUNW_OST_OSCMD catalog still contains the messages for locale (no delta) - I do not have any non-english translations handy to verify further.
  • Executed the now 64-bit locale with various subcommands (-a, -c, as well as with invalid commands) to confirm no change in behavior
Actions #5

Updated by Electric Monk 4 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 0245b61fd282e95735b173b8d95be0d6688163b4

commit  0245b61fd282e95735b173b8d95be0d6688163b4
Author: Garrett D'Amore <garrett@damore.org>
Date:   2022-07-30T19:06:55.000Z

    14859 locale command Makefiles could be simpler
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Reviewed by: Jason King <jason.brian.king+illumos@gmail.com>
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF