Project

General

Profile

Actions

Bug #14865

closed

mutex_tryenter:adaptive-acquire probe never fires

Added by Patrick Mooney 15 days ago. Updated about 9 hours ago.

Status:
Closed
Priority:
Normal
Category:
kernel
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

The lockstat probe for mutex_tryenter acquisition never seems to fire. As it turns out, that lock primitive has been passing the wrong argument to the lockstat probe for a long time:

        movq    %rdi, %rsi
        movl    $LS_MUTEX_ENTER_ACQUIRE, %edi
        jmp     lockstat_wrapper
        SET_SIZE(mutex_tryenter)

The LS_MUTEX_ENTER_ACQUIRE should be LS_MUTEX_TRYENTER_ACQUIRE instead.


Related issues

Related to illumos gate - Bug #14840: Modernize lockstat probesClosedPatrick Mooney

Actions
Actions #1

Updated by Patrick Mooney 15 days ago

  • Related to Bug #14840: Modernize lockstat probes added
Actions #2

Updated by Electric Monk 15 days ago

  • Gerrit CR set to 2256
Actions #3

Updated by Patrick Mooney 15 days ago

I noticed this while testing the individual instrumentation sites in #14840. With the proposed fix in place, the mutex_tryenter probe now fires, instead of being "merged" into the mutex_enter version.

Actions #4

Updated by Electric Monk about 9 hours ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit ee6ee36a8ff1701c4e61e6f118446b145220478c

commit  ee6ee36a8ff1701c4e61e6f118446b145220478c
Author: Patrick Mooney <pmooney@pfmooney.com>
Date:   2022-08-13T02:56:10.000Z

    14838 Rename erratum 147 handling
    14839 Untangle erratum 147 from lockstat
    14840 Modernize lockstat probes
    14865 mutex_tryenter:adaptive-acquire probe never fires
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Dan McDonald <danmcd@mnx.io>
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF