Project

General

Profile

Actions

Bug #14869

closed

ODX copy between shares fails

Added by Gordon Ross 2 months ago. Updated 13 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cifs - CIFS server and client
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:
racktop:BSR-9830

Description

On recent versions of Windows, copy/paste of a file in explorer will try to use server-side copy (ODX). That currently fails if you try it between two different shares.

Actions #1

Updated by Gordon Ross 2 months ago

  • Status changed from New to In Progress

Import this fix from github/Nexenta

commit 4fa23beff4629fae7d4ba2f18d9f1812e73f3d99
Author: Gordon Ross <gordon.ross@tintri.com>
Date:   Sat Mar 6 13:27:02 2021 -0500

    FIR-1470 ODX copy between shares fails
    FIR-1605 SMB ODX copy sees page_create_va contention

    Reviewed by: Yuri Pankov <ypankov@tintri.com>
    Reviewed by: Matt Barden <mbarden@tintri.com>
    Reviewed by: Evan Layton <elayton@tintri.com>
    Reviewed by: Prashanth Badari <prbadari@tintri.com>

44    8    usr/src/uts/common/fs/smbsrv/smb2_fsctl_odx.c

Actions #2

Updated by Electric Monk 2 months ago

  • Gerrit CR set to 2275
Actions #3

Updated by Gordon Ross 26 days ago

Ref. BSR-9830

Actions #4

Updated by Gordon Ross 19 days ago

Testing:

Copy paste a large file (400M ISO) from one share to another in Windows 10 file explorer.

smbsrv-tests
diff smbtor-smb2-20220913T211746.summary smbtor-smb2-20220916T124650.summary
(no change)

Actions #5

Updated by Gordon Ross 19 days ago

  • Status changed from In Progress to Pending RTI
Actions #6

Updated by Electric Monk 18 days ago

  • Status changed from Pending RTI to Closed
  • % Done changed from 0 to 100

git commit ba55de6b420021ddc0b5990dd680795ee33d4f94

commit  ba55de6b420021ddc0b5990dd680795ee33d4f94
Author: Gordon Ross <gordon.ross@tintri.com>
Date:   2022-09-16T22:45:39.000Z

    14869 ODX copy between shares fails
    Reviewed by: Yuri Pankov <ypankov@tintri.com>
    Reviewed by: Matt Barden <mbarden@tintri.com>
    Reviewed by: Evan Layton <elayton@tintri.com>
    Reviewed by: Prashanth Badari <prbadari@tintri.com>
    Approved by: Dan McDonald <danmcd@mnx.io>

Actions #7

Updated by Gordon Ross 13 days ago

  • External Bug set to racktop:BSR-9830
Actions

Also available in: Atom PDF