Project

General

Profile

Actions

Bug #14872

closed

smbios_info_processor forgot ext clock speed

Added by Robert Mustacchi 2 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

While working through the work in #14820 and adding new tests for the smbios_processor_t, I noticed that the external clock speed was always zero. The issue here was that smbios_info_processor() just forgot to actually process that value. We should add it in.


Related issues

Related to illumos gate - Feature #14820: Want SMBIOS 3.6 SupportClosedRobert Mustacchi

Actions
Actions #1

Updated by Robert Mustacchi 2 months ago

Actions #2

Updated by Electric Monk 2 months ago

  • Gerrit CR set to 2279
Actions #3

Updated by Robert Mustacchi 2 months ago

Here's an example of what this loos like before the fix for a given system:

rm@romulus ~ $ smbios -t4
ID    SIZE TYPE
75    136  SMB_TYPE_PROCESSOR (type 4) (processor)

  Manufacturer: Advanced Micro Devices, Inc.
  Version: AMD EPYC 7402P 24-Core Processor
  Serial Number: Unknown
  Asset Tag: Unknown
  Location Tag: P0
  Part Number: Unknown

  Family: 107 (AMD Zen Processor Family)
  CPUID: 0x178bfbff00830f10
  Type: 3 (central processor)
  Socket Upgrade: 55 (socket SP3)
  Socket Status: Populated
  Processor Status: 1 (enabled)
  Supported Voltages: 1.1V
  Core Count: 24
  Cores Enabled: 24
  Thread Count: 48
  Processor Characteristics: 0xfc
        SMB_PRC_64BIT (64-bit capable)
        SMB_PRC_MC (multi-core)
        SMB_PRC_HT (hardware thread)
        SMB_PRC_NX (execution protection)
        SMB_PRC_VT (enhanced virtualization)
        SMB_PRC_PM (power/performance control)
  External Clock Speed: Unknown
  Maximum Speed: 3350MHz
  Current Speed: 2800MHz
  L1 Cache Handle: 72
  L2 Cache Handle: 73
  L3 Cache Handle: 74

Note the fact that the external clock is unknown. However, I know that AMD expects that to be listed as a 100 MHz external clock (presumably because that's what they generate for PCIe in the chip even though the input crystal is different). With this, we now see the following:

rm@romulus ~ $ smbios -t4
ID    SIZE TYPE
75    136  SMB_TYPE_PROCESSOR (type 4) (processor)

  Manufacturer: Advanced Micro Devices, Inc.
  Version: AMD EPYC 7402P 24-Core Processor
  Serial Number: Unknown
  Asset Tag: Unknown
  Location Tag: P0
  Part Number: Unknown

  Family: 107 (AMD Zen Processor Family)
  CPUID: 0x178bfbff00830f10
  Type: 3 (central processor)
  Socket Upgrade: 55 (socket SP3)
  Socket Status: Populated
  Processor Status: 1 (enabled)
  Supported Voltages: 1.1V
  Core Count: 24
  Cores Enabled: 24
  Thread Count: 48
  Processor Characteristics: 0xfc
        SMB_PRC_64BIT (64-bit capable)
        SMB_PRC_MC (multi-core)
        SMB_PRC_HT (hardware thread)
        SMB_PRC_NX (execution protection)
        SMB_PRC_VT (enhanced virtualization)
        SMB_PRC_PM (power/performance control)
  External Clock Speed: 100MHz
  Maximum Speed: 3350MHz
  Current Speed: 2800MHz
  L1 Cache Handle: 72
  L2 Cache Handle: 73
  L3 Cache Handle: 74
  Threads Enabled: Unknown
Actions #4

Updated by Electric Monk 2 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 1d1fc316c9e8072a7e63a5b1218bab66b9a66b66

commit  1d1fc316c9e8072a7e63a5b1218bab66b9a66b66
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2022-08-07T00:00:13.000Z

    14820 Want SMBIOS 3.6 Support
    14872 smbios_info_processor forgot ext clock speed
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Rich Lowe <richlowe@richlowe.net>

Actions

Also available in: Atom PDF