Project

General

Profile

Actions

Bug #14873

closed

Retire ddi_getiminor()

Added by Garrett D'Amore 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Category:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

This function is a long obsolete function that was intended to support a version of the Sun Cluster product. In that product, the /dev/ filesystem had different notions of minor numbers that could require translation between "internal" (local to the node) and "external" (shared across the cluster) usages.

Only cluster aware products would have ever used this. It's extremely unlikely that any such products have ever existed that ran on Solaris 10 or later. (Perhaps unbundled Veritas file systems or something like that.)

Today this interface is a trivial wrapper around getminor().

There are no usages for it in gate, and it is believed that there no usages for it anywhere else either.

The manual page for this interface has factually incorrect information about when and where it can be used.

Actions #1

Updated by Garrett D'Amore 4 months ago

  • Assignee set to Garrett D'Amore
Actions #2

Updated by Garrett D'Amore 4 months ago

Additionally, the text has been steering folks away from this for a long time, with this false statement:

WARNINGS
Drivers are required to replace calls to ddi_getminor.9f by
getminor(9F)) in order to compile under Solaris 10 and later
versions.

Actions #3

Updated by Garrett D'Amore 4 months ago

Actually, the symbol is not exposed in the header files anymore. So nobody has been able to build with this without extraordinary measures on Solaris 10 and later.

Actions #4

Updated by Garrett D'Amore 4 months ago

  • Status changed from New to Pending RTI
  • % Done changed from 0 to 90
Actions #5

Updated by Garrett D'Amore 4 months ago

As there are no consumers of this API, testing is really just ensuring a clean build, and booting.

Actions #6

Updated by Electric Monk 4 months ago

  • Status changed from Pending RTI to Closed
  • % Done changed from 90 to 100

git commit b75a8b718b0b6c50c43b47b15603947383771a04

commit  b75a8b718b0b6c50c43b47b15603947383771a04
Author: Garrett D'Amore <garrett@damore.org>
Date:   2022-08-05T00:38:47.000Z

    14873 Retire ddi_getiminor()
    Reviewed by: Peter Tribble <peter.tribble@gmail.com>
    Approved by: Andrew Stormont <andyjstormont@gmail.com>
    Approved by: Dan McDonald <danmcd@mnx.io>

Actions

Also available in: Atom PDF