Project

General

Profile

Actions

Bug #14874

closed

Remove the SSA socal/sf and ssd drivers

Added by Garrett D'Amore about 2 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Category:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

The SPARC port supported FCAL devices via the "ssd" which was really SSA connected disks.

This was handled via three drives (ignoring the historical pln stuff that we don't have):

  • sf - low level bus
  • socal - optical loop driver
  • ssd - which was derived from sd, using a lot of ugly #defines

We should remove all this (SPARC is dead, and nobody with SPARC hardware has the relevant SSA hardware anyway).

This will allow us to clean up a lot of annoying mess in sd.c, which can benefit from any effort to clean it up. (It is mildly triggering to have to scroll past hundreds of lines of #defines to remap sd_xxx symbols to ssd_xxx.)

Note that SPARC downstreams could likely still benefit from this change, since it is incredibly unlikely that even they care about the legacy of SSA devices.

Actions #1

Updated by Electric Monk about 2 months ago

  • Gerrit CR set to 2281
Actions #2

Updated by Electric Monk about 2 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit cb1bb6c32d034ea24e8549ef763c9c2b79413eb8

commit  cb1bb6c32d034ea24e8549ef763c9c2b79413eb8
Author: Garrett D'Amore <garrett@damore.org>
Date:   2022-08-10T00:18:48.000Z

    14874 Remove the SSA socal/sf and ssd drivers
    Reviewed by: Peter Tribble <peter.tribble@gmail.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Dan McDonald <danmcd@mnx.io>

Actions #3

Updated by Garrett D'Amore about 2 months ago

Test notes: I’ve booted this with onu. Also, the sd binary is identical under elfcmp. (Nothing changed, no output from elfcmp comparing a binary build with and without this change.) This change was carefully crafted to avoid any changes that would have binary impact.

Actions

Also available in: Atom PDF