vmm_drv_test needs to be less IPS-dependent
During upstream merge of #14864 I discovered that the vmm_drv_test driver is depending on the IPS manifest, and strictly speaking it shouldn't.
I filed SmartOS bug OS-8401 (https://smartos.org/bugview/OS-8401) and committed https://github.com/TritonDataCenter/illumos-joyent/commit/cef7020412fbcaba82b6bbbc172e0f614dde1e80 to our downstream illumos. It appears to work for us, and since it leverages the already-in-gate techniques used in os-test's ksensor_test driver (#12830), we should make sure it is in -gate as well.
Updated by Joshua M. Clulow 9 days ago
To be clear, SmartOS doesn't have to use IPS, but should (and this is generally true) be using the manifests wholesale to construct the correct driver configuration across the board -- which also covers this. I don't think we want to avoid using the first class facilities we have for expressing driver metadata because of one distribution.
Updated by Dan McDonald 9 days ago
I mentioned the `ksensor_test` driver earlier, which does not have an IPS driver entry in its delivery to system-test-ostest.mf. Because it and vmm_drv_test are drivers purpose-built for testing, I thought maybe they should be consistent in their delivery.
Further inspection for "driver" and "drv" in $SRC/pkg/manifests/*test* yield a 50-50 split between in-IPS driver delivery, vs. module-only driver delivery. (Note that "driver" in the crypto tests is a dependency.)
nowhere(~/ws/illumos-gate)% grep -l /drv/ usr/src/pkg/manifests/*test* usr/src/pkg/manifests/system-bhyve-tests.p5m usr/src/pkg/manifests/system-file-system-zfs-tests.p5m usr/src/pkg/manifests/system-io-tests.p5m usr/src/pkg/manifests/system-test-ostest.p5m nowhere(~/ws/illumos-gate)% grep -l ^driver usr/src/pkg/manifests/*test* usr/src/pkg/manifests/system-bhyve-tests.p5m usr/src/pkg/manifests/system-file-system-zfs-tests.p5m nowhere(~/ws/illumos-gate)%
Clearly there's in-gate inconsistency here. Consider this issue my vote for (in the case of tests) module-only delivery. I can be convinced otherwise, however.