Project

General

Profile

Actions

Bug #14904

closed

pseudonex_detach does not properly check the detach command

Added by Robert Mustacchi about 2 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

The detach routine for the pseudo nexus driver does not properly check the command that we've been passed in from the DDI. As such, we could mistakenly detach the pseudo nexus when a new command was introduced that was not intended.

Actions #1

Updated by Electric Monk about 2 months ago

  • Gerrit CR set to 2303
Actions #2

Updated by Robert Mustacchi about 2 months ago

Note, this change is rather hard to test because detaching this nexus is practically impossible given the design of the system.

Actions #3

Updated by Electric Monk about 1 month ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit b38ce9deeb616a34a1a45672bd30512d64c6101b

commit  b38ce9deeb616a34a1a45672bd30512d64c6101b
Author: Robert Mustacchi <rm@joyent.com>
Date:   2022-08-16T22:36:21.000Z

    14903 The pseudo nexus should be FMA capable
    14904 pseudonex_detach does not properly check the detach command
    Reviewed by: Joshua M. Clulow <josh@sysmgr.org>
    Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Reviewed by: Andy Fiddaman <illumos@fiddaman.net>
    Approved by: Dan McDonald <danmcd@mnx.io>

Actions

Also available in: Atom PDF