Project

General

Profile

Actions

Feature #14926

closed

pcieadm cfgspace const crusade; use bitext.h

Added by Robert Mustacchi 4 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

While doing other work in pcieadm_cfgspace.c I thought it would be worth constifying most of the data tables. There's no reason they shouldn't be. While here, we can remove the use of the BITX macro and use the actual typed interfaces in <sys/bitext.h>.

Actions #1

Updated by Electric Monk 4 months ago

  • Gerrit CR set to 2317
Actions #2

Updated by Robert Mustacchi 3 months ago

To test this, I went through and constructed save configuration space values (e.g. save-cfgspace -a) and then I went through and dumped the state of everything with an older and newer version of the program and made sure that there was nothing that had changed due to this.

Actions #3

Updated by Electric Monk 3 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 4a8bbc0be937e3af518e40035ae2aaa61fa12fc2

commit  4a8bbc0be937e3af518e40035ae2aaa61fa12fc2
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2022-09-03T20:44:04.000Z

    14926 pcieadm cfgspace const crusade; use bitext.h
    Reviewed by: Patrick Mooney <pmooney@pfmooney.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions

Also available in: Atom PDF