Project

General

Profile

Actions

Feature #14943

open

pdevinfo.c error handling could use err.h

Added by Robert Mustacchi 3 months ago. Updated 3 months ago.

Status:
New
Priority:
Normal
Category:
cmd - userland programs
Start date:
Due date:
% Done:

0%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

The _error function attempts to use a NULL lead to determine whether or not to warn to try and use perror on the error after printing and interpreting the format string and characters. There's a lot of messy logic that's kind of hard to follow and actually all of these cases are then sometimes cast to void or then separately used to call exit(). In this case, The implementation here is basically the same as the err.h functions errx, err, warnx, and warn. While we're doing the cleanup in #14942 we should go ahead and do this at the same time.


Related issues

Related to illumos gate - Feature #14942: cleanup prtconf warning gagsNewRobert Mustacchi

Actions
Actions #1

Updated by Robert Mustacchi 3 months ago

  • Gerrit CR set to 2325
Actions #2

Updated by Robert Mustacchi 3 months ago

Actions

Also available in: Atom PDF