Project

General

Profile

Actions

Bug #14969

closed

Improve elfcap.chk CPPFLAGS

Added by Robert Mustacchi 2 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Category:
tools - gate/build tools
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

When we started with the design of elfcap.chk, it leveraged CPPFLAGS.native. Unfortunately, in stock situations for reasons that we need to separately sort out, CPPFLAGS.native will actually include an include to the proto area in some cases, particularly when you don't have a specific adjunct.

The original reason this didn't end up in the tools sgs build is that it would have made it much harder to rebuild with the updated elfcap.c pieces. This is why we ended up putting it in cmd/sgs so it's getting rebuilt and regularly rebuilt. A reasonable way to improve this is to through and point to the tools sgs proto area. This means that if there are updates to auxv.h, we'll need to go through and update that again. However, it does mean that changes to elfcap.c/h it'll still be rebuilt and checked.


Related issues

Related to illumos gate - Feature #14822: Need new word of hardware capabilitiesClosedRobert Mustacchi

Actions
Actions #1

Updated by Electric Monk 2 months ago

  • Gerrit CR set to 2350
Actions #2

Updated by Robert Mustacchi 2 months ago

  • Related to Feature #14822: Need new word of hardware capabilities added
Actions #3

Updated by Dan McDonald 2 months ago

I'm happy to report that with this fix in place, SmartOS builds without trainwrecking on building elfcap.chk. (Count this as real-world testing, advocates.)

Actions #4

Updated by Robert Mustacchi 2 months ago

I've also tested this with various builds to verify that it works in the new construction.

Actions #5

Updated by Electric Monk 2 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 73ef486937f03be7d079065dda822f13cc8f6470

commit  73ef486937f03be7d079065dda822f13cc8f6470
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2022-09-20T14:52:49.000Z

    14969 Improve elfcap.chk CPPFLAGS
    Reviewed by: Gordon Ross <gordon.w.ross@gmail.com>
    Reviewed by: Dan McDonald <danmcd@mnx.io>
    Approved by: Joshua M. Clulow <josh@sysmgr.org>

Actions

Also available in: Atom PDF