Project

General

Profile

Actions

Bug #14976

open

SMB ioctl fixes (still) incomplete

Added by Dan McDonald 3 months ago. Updated 21 days ago.

Status:
New
Priority:
Normal
Assignee:
Category:
smb - SMB server and client
Start date:
Due date:
% Done:

0%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

For reasons lost to time and job-changes, #8935 did not include a uint32_t {under,over}flow component. Something maybe about it being overkill in the two cases?

Recent merge conflicts in these areas have made me reconsider the full Joyent changes to these files, which I have cherrypicked to the top of the latest illumos-gate. Part of it was lost in SmartOS when we merged 8935, but the other part is still working in SmartOS despite never making it upstream. We can hash that out on the gerrit/review side.


Related issues

Related to illumos gate - Bug #8935: SMB ioctl fixes incompleteClosedDan McDonald2017-12-22

Actions
Actions #1

Updated by Electric Monk 3 months ago

  • Gerrit CR set to 2353
Actions #2

Updated by Dan McDonald 3 months ago

  • Related to Bug #8935: SMB ioctl fixes incomplete added
Actions #3

Updated by Gordon Ross 21 days ago

Just to follow up: I think the existing checks already cover the cases that led to the changes in the linked CR.

Actions

Also available in: Atom PDF