Project

General

Profile

Actions

Bug #14979

open

pci-ide lives in common but is i86pc-specific

Added by Thirteen Oxide 10 days ago.

Status:
New
Priority:
Low
Assignee:
-
Category:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

The pci-ide driver references, and depends upon the type of, objects attached to struct intrspec via the ih_private member. This member is intended for machine-dependent use, and is defined in machine-specific headers e.g. uts/i86pc/sys/mach_intr.h. An example of offending code is:

        case DDI_INTROP_ADDISR:
                if ((ispecp = pciide_get_ispec(dip, rdip, hdlp->ih_inum)) ==
                    NULL)
                        return (DDI_FAILURE);
                ((ihdl_plat_t *)hdlp->ih_private)->ip_ispecp = ispecp;
                ispecp->intrspec_func = hdlp->ih_cb_func;
                break;

Given the age of this code and the obsolescence of the devices it supports, it's almost certainly not worth fixing. It's also very unlikely that any new architectures will provide or support these devices. Therefore the best approach is to move this machine-dependent driver -- it's already built in uts/i86pc and delivered in /platform/i86pc -- source code into uts/i86pc.

No data to display

Actions

Also available in: Atom PDF