Project

General

Profile

Actions

Bug #14980

open

pcmcia lives in common but is i86pc-specific

Added by Thirteen Oxide 10 days ago.

Status:
New
Priority:
Low
Assignee:
-
Category:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

There are several places in uts/common/pcmcia/... where the code relies on the type and contents of objects attached to the ih_private member of interrupt handles. This is incorrect for at least two reasons: first, pcmcia purports to be common code and is even built and delivered in the machine-independent uts/intel and /kernel/drv respectively, but the ihdl_plat_t type is machine-dependent. Second, while the existence of a type with this name might conceivably be considered part of a contracted consolidation private interface (I could find no evidence for this, but that doesn't mean it couldn't be so), the contents of the type are clearly intended to be machine-specific. Common code should not be consuming them.

This code is probably no longer useful and could be removed, but the simplest and least disruptive solution is to move it to uts/i86pc and deliver it in /platform/i86pc. While there were cardbus/pc-card/pcmcia implementations that did not have x86 processors, the only ones that were not PCs were SPARC machines that are now obsolete per IPD 19. The removal of this code is itself proposed by IPD 26 and #5075 . One way or another, it needs to be moved out of usr/src/uts/common... whether to i86pc or the bin matter little.

No data to display

Actions

Also available in: Atom PDF