Project

General

Profile

Actions

Feature #15011

closed

Want wrapper for rpc tests in smbsrv-tests

Added by Matt Barden 3 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
tests
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

#14077 added a wrapper for smbtorture's smb2 tests to smbsrv-tests, as well as the infrastructure to run them through testrunner.
We'd like a similar wrapper for the rpc tests, so that we can exercise the MS-RPC services provided by the smb server.

This also fixes a few bugs identified during integration of #14077, including one related to python 3.9 support, and replaces instances of '.format()' with f-strings, now that Illumos defaults to a python version newer than 3.5.

Testing was done by running both the smb2 and rpc wrappers through smbsrv-tests.

Actions #1

Updated by Matt Barden 3 months ago

  • Subject changed from Add wrapper for smbtorture rpc tests to smbsrv-tests to Want wrapper for smbtorture rpc tests in smbsrv-tests
Actions #2

Updated by Matt Barden 3 months ago

  • Status changed from New to In Progress
Actions #3

Updated by Matt Barden 3 months ago

  • Description updated (diff)
Actions #4

Updated by Matt Barden 3 months ago

  • Subject changed from Want wrapper for smbtorture rpc tests in smbsrv-tests to Want wrapper for rpc tests in smbsrv-tests
Actions #5

Updated by Electric Monk 3 months ago

  • Gerrit CR set to 2394
Actions #6

Updated by Matt Barden 2 months ago

After these changes, the output looks like this:
SMB2 tests:

RESULTS:
======================
PASS:              196
FAIL:              131
UNKNOWN:             0
SKIP:               43
KILLED:              1
TEST_ERR:            0
======================
Total:             371
Excluded:           34

RPC tests:

RESULTS:
======================
PASS:               20
FAIL:              165
UNKNOWN:             0
SKIP:               15
KILLED:              1
TEST_ERR:            0
======================
Total:             201
Excluded:          294

Actions #7

Updated by Electric Monk 2 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit 1b38ec66a3ea040587c1b346f8c010a3b37c8080

commit  1b38ec66a3ea040587c1b346f8c010a3b37c8080
Author: Matt Barden <mbarden@tintri.com>
Date:   2022-10-05T03:16:26.000Z

    15011 Want wrapper for rpc tests in smbsrv-tests
    Reviewed by: Gordon Ross <gordon.w.ross@gmail.com>
    Reviewed by: Evan Layton <elayton@tintri.com>
    Approved by: Dan McDonald <danmcd@mnx.io>

Actions

Also available in: Atom PDF