Project

General

Profile

Actions

Bug #15013

closed

smbsrv: cannot rename file whose name was CATIA-converted

Added by Matt Barden 3 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
smb - SMB server and client
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

The SMB server allows setting a property called 'catia' on shares. This property converts characters in UNIX filenames that aren't valid in SMB filenames to other characters. This occasionally finds use in mixed-protocol workloads; for example, if an NFS client creates a file with a ':' character in the name (a valid UNIX filename), attempts to open it over SMB fail (':' is used to open named streams).

Attempts to rename a file whose name has been converted by the 'catia' option fail due to smb_fsop_rename() overwriting the 'CATIA' flag. This causes rename to attempt to open a file that doesn't exist.

Testing was done by verifying that files can be renamed with 'catia=true' is set on the share, whether or not they are name-converted, as well as when 'catia=false'.

Actions #1

Updated by Electric Monk 3 months ago

  • Gerrit CR set to 2396
Actions #2

Updated by Electric Monk 2 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit f40487698292848b93d33bbc76f92ca1c063e39e

commit  f40487698292848b93d33bbc76f92ca1c063e39e
Author: Matt Barden <mbarden@tintri.com>
Date:   2022-10-05T03:16:50.000Z

    15013 smbsrv: cannot rename file whose name was CATIA-converted
    Reviewed by: Gordon Ross <gordon.w.ross@gmail.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Prashanth Badari <prbadari@tintri.com>
    Reviewed by: Suresh Jayaraman <sjayaraman@tintri.com>
    Approved by: Dan McDonald <danmcd@mnx.io>

Actions

Also available in: Atom PDF