Project

General

Profile

Actions

Bug #15037

closed

cp_subr.s: Invalid instruction argument

Added by Toomas Soome 2 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

Build errors when 32-bit build got /bin/as for assembler (not gnu as). Despite the "wrong" assembler used, I still think the arguments should be fixed.

    Assembler: cp_subr.s
            "/code/illumos-gate/usr/src/lib/commpage/i386/cp_subr.s", line 87 : Invalid instruction argument
            "/code/illumos-gate/usr/src/lib/commpage/i386/cp_subr.s", line 134 : Invalid instruction argument
            "/code/illumos-gate/usr/src/lib/commpage/i386/cp_subr.s", line 199 : Invalid instruction argument
    *** Error code 127

Apparently this combination of registers is not allowed.

Testing done: compared object files, no difference detected.

Actions #1

Updated by Electric Monk 2 months ago

  • Gerrit CR set to 2413
Actions #2

Updated by Toomas Soome 2 months ago

  • Description updated (diff)
Actions #3

Updated by Toomas Soome about 2 months ago

  • Description updated (diff)
Actions #4

Updated by Toomas Soome about 2 months ago

  • Status changed from In Progress to Pending RTI
Actions #5

Updated by Electric Monk about 2 months ago

  • Status changed from Pending RTI to Closed
  • % Done changed from 90 to 100

git commit 3cc2454804c6ebaa0b2a607ad425214c1e51c4ee

commit  3cc2454804c6ebaa0b2a607ad425214c1e51c4ee
Author: Toomas Soome <tsoome@me.com>
Date:   2022-10-11T19:16:25.000Z

    15037 cp_subr.s: Invalid instruction argument
    Reviewed by: Dan Cross <cross@oxidecomputer.com>
    Reviewed by: Patrick Mooney <pmooney@pfmooney.com>
    Reviewed by: Rich Lowe <richlowe@richlowe.net>
    Approved by: Dan McDonald <danmcd@mnx.io>

Actions

Also available in: Atom PDF