Project

General

Profile

Actions

Bug #15041

closed

smbadm join reports clock skew as bad password

Added by Toomas Soome 2 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
smb - SMB server and client
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:
racktop:BSR-10004

Description

Distinguish errors from getting initial credentials.

Actions #1

Updated by Electric Monk 2 months ago

  • Gerrit CR set to 2416
Actions #2

Updated by Gordon Ross about 2 months ago

AD join fails if your clock too far out of sync with the AD servers.
That's normal, but if we fail due to that, we should report it better.

For testing this, one can force the system time a day behind, eg

root@oitest:/# date
October 15, 2021 at 04:42:11 PM EDT
root@oitest:/# date 10141642
October 14, 2021 at 04:42:00 PM EDT
root@oitest:/# date
October 14, 2021 at 04:42:01 PM EDT

Before the fix an attempt to join AD with your clock too far off looks like this:

root@oitest:/# smbadm join -u gwr contoso.com
After joining contoso.com the smb service will be restarted automatically.
Would you like to continue? [no]: yes
Enter domain password: 
Joining contoso.com ... this may take a minute ...
failed to join domain contoso.com
using AD server: dc-01.contoso.com
Failed getting initial credentials.  (Wrong password?)
Please refer to the service log for more information.

Example of what it looks like with the reporting fixed.

root@oitest:/# smbadm join -u gwr contoso.com
After joining contoso.com the smb service will be restarted automatically.
Would you like to continue? [no]: yes
Enter domain password: 
Joining contoso.com ... this may take a minute ...
failed to join domain contoso.com
using AD server: dc-01.contoso.com
Failed getting initial credentials.  (Clock skew too great)
Please refer to the service log for more information.

Actions #3

Updated by Toomas Soome about 2 months ago

  • Status changed from In Progress to Pending RTI
Actions #4

Updated by Electric Monk about 2 months ago

  • Status changed from Pending RTI to Closed
  • % Done changed from 90 to 100

git commit 7b0b8123e6101089b9e44e31f6b14b0762845fbb

commit  7b0b8123e6101089b9e44e31f6b14b0762845fbb
Author: Gordon Ross <gwr@racktopsystems.com>
Date:   2022-10-11T19:19:43.000Z

    15041 smbadm join reports clock skew as bad password
    Reviewed by: Matt Barden <mbarden@tintri.com>
    Approved by: Dan McDonald <danmcd@mnx.io>

Actions

Also available in: Atom PDF