Project

General

Profile

Actions

Feature #15045

closed

SMB should implement FSCTL_DFS_GET_REFERRALS_EX

Added by Toomas Soome 2 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
smb - SMB server and client
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:
racktop:BSR-10238

Description

Implement support for FSCTL_DFS_GET_REFERRALS_EX.


Related issues

Related to illumos gate - Bug #15044: SMB should return NT_STATUS_FS_DRIVER_REQUIRED for DFS ioctls when DFS is not supportedClosedToomas Soome

Actions
Actions #1

Updated by Electric Monk 2 months ago

  • Gerrit CR set to 2420
Actions #2

Updated by Gordon Ross about 2 months ago

  • Related to Bug #15044: SMB should return NT_STATUS_FS_DRIVER_REQUIRED for DFS ioctls when DFS is not supported added
Actions #3

Updated by Gordon Ross about 2 months ago

BTW, tested this with a private (hacked up) smbtorture test. It's on the smb2dfs branch in our smbtorture repo.
Here's what it looks like running it, after the bug is fixed: {code}
$ UNC='\\\\server\\test' bin/smbtorture -U test%test '//server/IPC$' smb2.dfs
smbtorture 4.10.8
Using seed 1647037349
time: 2022-03-11 22:22:29.179877
progress: 2
test: get_root_referral
time: 2022-03-11 22:22:29.180959
time: 2022-03-11 22:22:29.330668
failure: get_root_referral [
../../source4/torture/smb2/dfs.c:99: smb2_dfs_cli_call(tree, &r) was NT_STATUS_NOT_FOUND, expected NT_STATUS_OK: Get Domain referral failed
]
test: get_root_referral_ex
time: 2022-03-11 22:22:29.331303
time: 2022-03-11 22:22:29.473076
failure: get_root_referral_ex [
../../source4/torture/smb2/dfs.c:200: smb2_dfs_cli_call_ex(tree, &r) was NT_STATUS_NOT_FOUND, expected NT_STATUS_OK: Get Domain referral failed
] {code}
Note that "not found" is a normal response when a share has no referral links.

The point of the test is to observe that the server answered the "get root referral EX" call.

Actions #4

Updated by Electric Monk about 2 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 2067ad9da908e7634f4b17778a0523d3acca8102

commit  2067ad9da908e7634f4b17778a0523d3acca8102
Author: Gordon Ross <gwr@racktopsystems.com>
Date:   2022-10-14T20:08:24.000Z

    15045 SMB should implement FSCTL_DFS_GET_REFERRALS_EX
    Reviewed-by: Jerry Jelinek <gjelinek@racktopsystems.com>
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Reviewed by: Jason King <jason.brian.king+illumos@gmail.com>
    Reviewed by: Matt Barden <mbarden@tintri.com>
    Approved by: Dan McDonald <danmcd@mnx.io>

Actions

Also available in: Atom PDF