Project

General

Profile

Actions

Bug #15344

closed

Fix casts from (void *) to (void)

Added by Marco van Wieringen about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

Some code uses a cast to (void *) which should be (void) as its only to ignore the return value of the function.

Actions #1

Updated by Electric Monk about 1 year ago

  • Gerrit CR set to 2610
Actions #2

Updated by Marco van Wieringen about 1 year ago

Tested netstat, sasinfo and format binary from proto area and they work the same as before. Rest is a bit difficult to test without rebooting into a new BE. given the little change should be ok however.

Actions #3

Updated by Marco van Wieringen about 1 year ago

Performed dis on the before and after binaries of netstat, powerd and sasinfo and the are exactly the aame.

Actions #4

Updated by Electric Monk about 1 year ago

  • Status changed from In Progress to Closed

git commit b172429eb7fa68712e018d8965b6d0c7f6779f9e

commit  b172429eb7fa68712e018d8965b6d0c7f6779f9e
Author: Marco van Wieringen <marco.van.wieringen@planets.elm.net>
Date:   2023-01-29T19:25:39.000Z

    15344 Fix casts from (void *) to (void)
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Bill Sommerfeld <sommerfeld@alum.mit.edu>
    Approved by: Dan McDonald <danmcd@mnx.io>

Actions

Also available in: Atom PDF