Project

General

Profile

Actions

Bug #15512

open

zfs: Check the dataset type more rigorously when fetching properties.

Added by Toomas Soome 2 months ago. Updated 2 months ago.

Status:
In Progress
Priority:
Normal
Assignee:
Category:
zfs - Zettabyte File System
Start date:
Due date:
% Done:

90%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

Picking update from OpenZFS:

commit 962d52421236fc9cd61d59b4f18cff3276077da9
Author: Tim Chase <tim@chase2k.com>
Date:   Mon Apr 21 13:22:08 2014 -0500

    Check the dataset type more rigorously when fetching properties.

    When fetching property values of snapshots, a check against the head
    dataset type must be performed.  Previously, this additional check was
    performed only when fetching "version", "normalize", "utf8only" or "case".

    This caused the ZPL properties "acltype", "exec", "devices", "nbmand",
    "setuid" and "xattr" to be erroneously displayed with meaningless values
    for snapshots of volumes.  It also did not allow for the display of
    "volsize" of a snapshot of a volume.

    This patch adds the headcheck flag paramater to zfs_prop_valid_for_type()
    and zprop_valid_for_type() to indicate the check is being done
    against a head dataset's type in order that properties valid only for
    snapshots are handled correctly.  This allows the the head check in
    get_numeric_property() to be performed when fetching a property for
    a snapshot.

    Signed-off-by: Tim Chase <tim@chase2k.com>
    Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
    Closes #2265

This is prerequisite work for next updates...


Related issues

Related to illumos gate - Bug #15511: zfs: Unify mount and share for 'zfs create/clone'In ProgressToomas Soome

Actions
Actions #1

Updated by Toomas Soome 2 months ago

  • Related to Bug #15511: zfs: Unify mount and share for 'zfs create/clone' added
Actions #2

Updated by Electric Monk 2 months ago

  • Gerrit CR set to 2741
Actions

Also available in: Atom PDF