Project

General

Profile

Actions

Bug #15602

closed

loader: gzipfs should follow NFSREAD_MAX_SIZE

Added by Toomas Soome about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

While debugging ip fragment handling, I noticed the boot archive was always read by 2024 bytes requests (despite nfs.read_size was set larger value). It did turn out to be read size limit from gzipfs, where we read to fixed size 2k buffer. Since there is currently no way to negotiate max logical read size with IO device, we can just increase the Z_BUFSIZE for gzipfs to match the nfs.

PS: actually next limit is with load command, which is reading by 4k chunks.

Testing done: observed the boot archive reads can get larger than 2049 bytes.

Actions #1

Updated by Electric Monk about 1 year ago

  • Gerrit CR set to 2793
Actions #2

Updated by Toomas Soome about 1 year ago

  • Status changed from In Progress to Pending RTI
Actions #3

Updated by Electric Monk about 1 year ago

  • Status changed from Pending RTI to Closed
  • % Done changed from 90 to 100

git commit fd5b2b1f858c62e1ccb809d6dc3c5a39727af6d8

commit  fd5b2b1f858c62e1ccb809d6dc3c5a39727af6d8
Author: Toomas Soome <tsoome@me.com>
Date:   2023-05-02T11:35:08.000Z

    15602 loader: gzipfs should follow NFSREAD_MAX_SIZE
    Reviewed by: Bill Sommerfeld <sommerfeld@alum.mit.edu>
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Approved by: Patrick Mooney <pmooney@pfmooney.com>

Actions

Also available in: Atom PDF