Actions
Bug #15700
openarcmsr: the comparison will always evaluate as 'true'
Start date:
Due date:
% Done:
90%
Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:
Description
Build errors with gcc 12:
../../intel/io/scsi/adapters/arcmsr/arcmsr.c: In function 'arcmsr_report_sense_info': ../../intel/io/scsi/adapters/arcmsr/arcmsr.c:2098:40: error: the comparison will always evaluate as 'true' for the address of 'sts_sensedata' will never be NULL [-Werror=address] 2098 | if (&arq_status->sts_sensedata != NULL) { | ^~ In file included from ../../common/sys/scsi/scsi_types.h:91, from ../../common/sys/scsi/scsi.h:34, from ../../intel/io/scsi/adapters/arcmsr/arcmsr.c:56: ../../common/sys/scsi/generic/status.h:78:36: note: 'sts_sensedata' declared here 78 | struct scsi_extended_sense sts_sensedata; | ^~~~~~~~~~~~~ ../../intel/io/scsi/adapters/arcmsr/arcmsr.c: In function 'arcmsr_iop_message_xfer': ../../intel/io/scsi/adapters/arcmsr/arcmsr.c:4358:56: error: the comparison will always evaluate as 'true' for the address of 'sts_sensedata' will never be NULL [-Werror=address] 4358 | if (&arq_status->sts_sensedata != NULL) { | ^~ ../../common/sys/scsi/generic/status.h:78:36: note: 'sts_sensedata' declared here 78 | struct scsi_extended_sense sts_sensedata; | ^~~~~~~~~~~~~ ../../intel/io/scsi/adapters/arcmsr/arcmsr.c:4410:64: error: the comparison will always evaluate as 'true' for the address of 'sts_sensedata' will never be NULL [-Werror=address] 4410 | if (&arq_status->sts_sensedata != NULL) { | ^~ ../../common/sys/scsi/generic/status.h:78:36: note: 'sts_sensedata' declared here 78 | struct scsi_extended_sense sts_sensedata; | ^~~~~~~~~~~~~ cc1: all warnings being treated as errors
Testing done: build/install/boot, but I do not have the hardware, so can not confirm the working driver.
Updated by Toomas Soome 5 days ago
- Description updated (diff)
- Status changed from In Progress to Pending RTI
Actions