Project

General

Profile

Bug #1597

bge regression on some older hardware

Added by Garrett D'Amore almost 8 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Normal
Category:
driver - device drivers
Start date:
2011-10-05
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

bge doesn't initialize properly on some older hardware. The problem is that an excessive delay is used during initialization which causes problems.

At Nexenta, we have had a change to remove this delay in production for well over a year, and we would like to get this change into illumos.

Here's the diff:


diff -r 1e427a2a00fe -r 0b825b368dab usr/src/uts/common/io/bge/bge_chip2.c
--- a/usr/src/uts/common/io/bge/bge_chip2.c
+++ b/usr/src/uts/common/io/bge/bge_chip2.c
@@ -3123,8 +3123,6 @@
                for (i = 0; i < 1000; ++i) {
                        drv_usecwait(1000);
                        gen = bge_nic_get64(bgep, NIC_MEM_GENCOMM) >> 32;
-                       if (i == 0 && DEVICE_5704_SERIES_CHIPSETS(bgep))
-                               drv_usecwait(100000);
                        mac = bge_reg_get64(bgep, MAC_ADDRESS_REG(0));
 #ifdef BGE_IPMI_ASF
                        if (!bgep->asf_enabled) {


Related issues

Related to illumos gate - Feature #3446: Update bge to support missing 57xx/577xx devicesClosed2015-04-06

Actions

History

#1

Updated by Garrett D'Amore almost 8 years ago

Notably, other FOSS don't have this delay either.

#2

Updated by Garrett D'Amore over 7 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 80 to 100

Fixed in

changeset: 13484:336a3bc9a633
tag: tip
user: Garrett D'Amore <>
date: Tue Oct 18 08:05:58 2011 -0700
description:
1597 bge regression on some older hardware
Reviewed by: Eric Schrock <>
Reviewed by: Igor Kozhukhov <>
Reviewed by: Milan Jurik <>
Reviewed by: Albert Lee <>
Approved by: Gordon Ross <>

Also available in: Atom PDF