Project

General

Profile

Actions
Copy link

Bug #16044

open

NVMe spec version message could use a newline

Added by Jason King 21 days ago. Updated 21 days ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
driver - device drivers
Start date:
Due date:
% Done:

0%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

From nvme_init():

    dev_err(nvme->n_dip, CE_CONT, "?NVMe spec version %d.%d",
         nvme->n_version.v_major, nvme->n_version.v_minor);

Since it is using CE_CONT, a newline is not appended to the message. As a result during verbose booting, whatever follows it is concatenated onto the same line.

Actions
Copy link
 #1

Updated by Rich Lowe 21 days ago

We really need to stop using CE_CONT for anything other than it's meant for. These problems are everywhere.

Actions
Copy link
 #2

Updated by Rich Lowe 21 days ago

I filed #16045 so maybe we can stop having to fix these things someday.

Actions
Copy link

Also available in: Atom PDF