Project

General

Profile

Actions

Bug #16191

closed

bhyve tests failing after 2023 upstream sync

Added by Patrick Mooney 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Category:
bhyve
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

After #15916 was merged, a couple of tests from the bhyve-test suite are failing:

Test: /opt/bhyve-tests/tests/inst_emul/page_dirty (run as root)   [00:00] [FAIL]
Test: /opt/bhyve-tests/tests/vmm/maxcpu (run as root)             [00:00] [FAIL]

Related issues

Related to illumos gate - Feature #15916: bhyve upstream sync 2023 SeptemberClosedAndy Fiddaman

Actions
Actions #1

Updated by Patrick Mooney 4 months ago

Actions #2

Updated by Electric Monk 4 months ago

  • Gerrit CR set to 3234
Actions #3

Updated by Patrick Mooney 4 months ago

With the proposed fix in place, all the tests are passing again:

Test: /opt/bhyve-tests/tests/mevent/vnode_zvol (run as root)      [00:02] [PASS]
Test: /opt/bhyve-tests/tests/inst_emul/cpuid (run as root)        [00:00] [PASS]
Test: /opt/bhyve-tests/tests/inst_emul/imul (run as root)         [00:00] [PASS]
Test: /opt/bhyve-tests/tests/inst_emul/rdmsr (run as root)        [00:00] [PASS]
Test: /opt/bhyve-tests/tests/inst_emul/wrmsr (run as root)        [00:00] [PASS]
Test: /opt/bhyve-tests/tests/inst_emul/triple_fault (run as root) [00:00] [PASS]
Test: /opt/bhyve-tests/tests/inst_emul/exit_paging (run as root)  [00:00] [PASS]
Test: /opt/bhyve-tests/tests/inst_emul/page_dirty (run as root)   [00:00] [PASS]
Test: /opt/bhyve-tests/tests/inst_emul/exit_consistent (run as root) [00:00] [PASS]
Test: /opt/bhyve-tests/tests/inst_emul/suspend_info (run as root) [00:00] [PASS]
Test: /opt/bhyve-tests/tests/inst_emul/vcpu_barrier (run as root) [00:00] [PASS]
Test: /opt/bhyve-tests/tests/kdev/vatpit_freq (run as root)       [00:00] [PASS]
Test: /opt/bhyve-tests/tests/kdev/vhpet_freq (run as root)        [00:00] [PASS]
Test: /opt/bhyve-tests/tests/kdev/vlapic_freq (run as root)       [00:00] [PASS]
Test: /opt/bhyve-tests/tests/kdev/vlapic_freq_periodic (run as root) [00:00] [PASS]
Test: /opt/bhyve-tests/tests/kdev/vlapic_mmio_access (run as root) [00:00] [PASS]
Test: /opt/bhyve-tests/tests/kdev/vlapic_msr_access (run as root) [00:00] [PASS]
Test: /opt/bhyve-tests/tests/kdev/vpmtmr_freq (run as root)       [00:00] [PASS]
Test: /opt/bhyve-tests/tests/kdev/vrtc_ops (run as root)          [00:04] [PASS]
Test: /opt/bhyve-tests/tests/kdev/wrmsr_tsc (run as root)         [00:00] [PASS]
Test: /opt/bhyve-tests/tests/kdev/rdmsr_tsc (run as root)         [00:00] [PASS]
Test: /opt/bhyve-tests/tests/mevent/lists_delete (run as root)    [00:00] [PASS]
Test: /opt/bhyve-tests/tests/mevent/read_disable (run as root)    [00:00] [PASS]
Test: /opt/bhyve-tests/tests/mevent/read_pause (run as root)      [00:00] [PASS]
Test: /opt/bhyve-tests/tests/mevent/read_requeue (run as root)    [00:00] [PASS]
Test: /opt/bhyve-tests/tests/mevent/vnode_file (run as root)      [00:09] [PASS]
Test: /opt/bhyve-tests/tests/viona/interface_version (run as root) [00:00] [PASS]
Test: /opt/bhyve-tests/tests/vmm/auto_destruct (run as root)      [00:00] [PASS]
Test: /opt/bhyve-tests/tests/vmm/cpuid_ioctl (run as root)        [00:00] [PASS]
Test: /opt/bhyve-tests/tests/vmm/datarw_constraints (run as root) [00:00] [PASS]
Test: /opt/bhyve-tests/tests/vmm/datarw_msrs (run as root)        [00:00] [PASS]
Test: /opt/bhyve-tests/tests/vmm/datarw_vcpu (run as root)        [00:00] [PASS]
Test: /opt/bhyve-tests/tests/vmm/default_capabs (run as root)     [00:00] [PASS]
Test: /opt/bhyve-tests/tests/vmm/drv_hold (run as root)           [00:00] [PASS]
Test: /opt/bhyve-tests/tests/vmm/fpu_getset (run as root)         [00:00] [PASS]
Test: /opt/bhyve-tests/tests/vmm/import_vlapic (run as root)      [00:00] [PASS]
Test: /opt/bhyve-tests/tests/vmm/interface_version (run as root)  [00:00] [PASS]
Test: /opt/bhyve-tests/tests/vmm/legacy_destruct (run as root)    [00:00] [PASS]
Test: /opt/bhyve-tests/tests/vmm/maxcpu (run as root)             [00:00] [PASS]
Test: /opt/bhyve-tests/tests/vmm/mem_devmem (run as root)         [00:00] [PASS]
Test: /opt/bhyve-tests/tests/vmm/mem_partial (run as root)        [00:00] [PASS]
Test: /opt/bhyve-tests/tests/vmm/mem_seg_map (run as root)        [00:00] [PASS]
Test: /opt/bhyve-tests/tests/vmm/pause_resume (run as root)       [00:00] [PASS]
Test: /opt/bhyve-tests/tests/vmm/self_destruct (run as root)      [00:00] [PASS]

Results Summary
PASS      44

Running Time:   00:00:19
Percent passed: 100.0%

Actions #4

Updated by Dan McDonald 4 months ago

Our bhyve tests aren't always 100% accurate because we use a VMware Fusion VM for first-line testing. Otherwise I would've spoken up sooner.

We did detect vmm/maxcpu failures post-upstream, so happy to have this reported and fixed.

kebe(~/smartos-tests)[1]% grep vmm/maxcpu */*/*/log | grep -v PASS
rc-20240111/test_results/20240110T213919/log:Test: /opt/bhyve-tests/tests/vmm/maxcpu (run as root)             [00:00] [FAIL]
release-20240111-DEBUG/test_results/20240111T203237/log:Test: /opt/bhyve-tests/tests/vmm/maxcpu (run as root)             [00:00] [FAIL]
release-20240111/test_results/20240111T032443/log:Test: /opt/bhyve-tests/tests/vmm/maxcpu (run as root)             [00:00] [FAIL]
kebe(~/smartos-tests)[0]% grep vmm/maxcpu */*/*/log | wc -l
      31
kebe(~/smartos-tests)[0]% 

Actions #5

Updated by Electric Monk 4 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit 9572e5c8dedd7c7dac9771cb4536ebad06b4e226

commit  9572e5c8dedd7c7dac9771cb4536ebad06b4e226
Author: Patrick Mooney <pmooney@pfmooney.com>
Date:   2024-01-17T18:28:56.000Z

    16191 bhyve tests failing after 2023 upstream sync
    Reviewed by: Andy Fiddaman <illumos@fiddaman.net>
    Approved by: Dan McDonald <danmcd@mnx.io>

Actions

Also available in: Atom PDF