Project

General

Profile

Actions

Bug #16241

closed

lmrc shouldn't panic on unknown MFI completion status

Added by Hans Rosenfeld 15 days ago. Updated 8 days ago.

Status:
Closed
Priority:
Normal
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

Maurilio Longo reported a panic in lmrc on his HPE ML30 Gen9, which uses a MR216i-p HBA:

command failed, status = 76, ex_status = 0, cdb[0] = 1b

I've looked other drivers, and not even Linux knows what status 0x76 means. But perhaps we shouldn't panic because of this and just map this to CMD_TRAN_ERR.

Actions #1

Updated by Electric Monk 15 days ago

  • Gerrit CR set to 3261
Actions #2

Updated by Hans Rosenfeld 14 days ago

Testing: I built a custom OmniOS bloody ISO with this fix applied. Maurilio Longo reported that the system wasn't panicking anymore with this, all disks were visible and usable.

Actions #3

Updated by Electric Monk 8 days ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit d25078f9b67c7f6d618dbd13c0675774ac00345e

commit  d25078f9b67c7f6d618dbd13c0675774ac00345e
Author: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>
Date:   2024-02-13T17:08:40.000Z

    16241 lmrc shouldn't panic on unknown MFI completion status
    Reviewed by: Andy Fiddaman <illumos@fiddaman.net>
    Reviewed by: Bill Sommerfeld <sommerfeld@hamachi.org>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Vitaliy Gusev <gusev.vitaliy@gmail.com>
    Approved by: Dan McDonald <danmcd@mnx.io>

Actions

Also available in: Atom PDF