Project

General

Profile

Actions

Bug #16252

closed

mail: type of 'errnum' defaults to 'int'

Added by Toomas Soome 12 days ago. Updated 9 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

Building with modern compiler will complain:

doopen.c: In function 'doopen':
doopen.c:35:1: error: type of 'errnum' defaults to 'int' [-Werror=implicit-int]
 doopen(file, type, errnum)
 ^~~~~~
cc1: all warnings being treated as errors

And some more like that.

Testing done: wsdiff does not report binary differences:

tsoome@beastie:/code/16252$ grep NOTE: report.txt 
NOTE: ASCII difference detected.
NOTE: ASCII difference detected.
NOTE: ASCII difference detected.
NOTE: ASCII difference detected.
NOTE: ASCII difference detected.

Actions #1

Updated by Electric Monk 12 days ago

  • Gerrit CR set to 3269
Actions #2

Updated by Toomas Soome 10 days ago

  • Description updated (diff)
  • Status changed from In Progress to Pending RTI
Actions #3

Updated by Electric Monk 9 days ago

  • Status changed from Pending RTI to Closed
  • % Done changed from 90 to 100

git commit 4c2b696569f2aa6e3b0a14243bfe9603f1cece11

commit  4c2b696569f2aa6e3b0a14243bfe9603f1cece11
Author: Toomas Soome <tsoome@me.com>
Date:   2024-02-12T20:29:31.000Z

    16252 mail: type of 'errnum' defaults to 'int'
    Reviewed by: Marcel Telka <marcel@telka.sk>
    Reviewed by: Dan Cross <cross@oxidecomputer.com>
    Reviewed by: Bill Sommerfeld <sommerfeld@hamachi.org>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF