Project

General

Profile

Actions

Bug #16255

closed

lpadmin: type of 'sig' defaults to 'int'

Added by Toomas Soome 12 days ago. Updated 8 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

Build errors with modern options:

    signals.c: In function 'catch':
    signals.c:50:1: error: type of 'sig' defaults to 'int' [-Werror=implicit-int]
       50 | catch (sig)
          | ^~~~~
    cc1: all warnings being treated as errors

Testing done: wsdiff - no binary differences.

tsoome@omnios:/code/16255$ grep NOTE: report.txt 
NOTE: ASCII difference detected.
NOTE: ASCII difference detected.
tsoome@omnios:/code/16255$ 
Actions #1

Updated by Electric Monk 12 days ago

  • Gerrit CR set to 3272
Actions #2

Updated by Toomas Soome 9 days ago

  • Description updated (diff)
  • Status changed from In Progress to Pending RTI
Actions #3

Updated by Electric Monk 8 days ago

  • Status changed from Pending RTI to Closed
  • % Done changed from 90 to 100

git commit 6241c4c03f3d3ec98fdfb2b2b91b7dfcaddb4f53

commit  6241c4c03f3d3ec98fdfb2b2b91b7dfcaddb4f53
Author: Toomas Soome <tsoome@me.com>
Date:   2024-02-13T19:03:51.000Z

    16255 lpadmin: type of 'sig' defaults to 'int'
    Reviewed by: Peter Tribble <peter.tribble@gmail.com>
    Reviewed by: Dan Cross <cross@oxidecomputer.com>
    Reviewed by: Bill Sommerfeld <sommerfeld@hamachi.org>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Actions

Also available in: Atom PDF