Project

General

Profile

Actions

Bug #16256

closed

backup: type of 'status' defaults to 'int'

Added by Toomas Soome 12 days ago. Updated 7 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

Build errors with modern options:

    dumptape.c: In function 'Exit':
    dumptape.c:1640:1: error: type of 'status' defaults to 'int' [-Werror=implicit-int]
     1640 | Exit(status)
          | ^~~~
    cc1: all warnings being treated as errors

Testing done: wsdiff does not report binary differences.

tsoome@beastie:/code/16256$ grep NOTE: report.txt 
NOTE: ASCII difference detected.
NOTE: ASCII difference detected.
tsoome@beastie:/code/16256$
Actions #1

Updated by Electric Monk 12 days ago

  • Gerrit CR set to 3273
Actions #2

Updated by Toomas Soome 8 days ago

  • Description updated (diff)
  • Status changed from In Progress to Pending RTI
Actions #3

Updated by Electric Monk 7 days ago

  • Status changed from Pending RTI to Closed
  • % Done changed from 90 to 100

git commit 9dc144f65c744c86a4ba1fdcad2eafef2f7daf63

commit  9dc144f65c744c86a4ba1fdcad2eafef2f7daf63
Author: Toomas Soome <tsoome@me.com>
Date:   2024-02-14T21:22:32.000Z

    16256 backup: type of 'status' defaults to 'int'
    Reviewed by: Peter Tribble <peter.tribble@gmail.com>
    Reviewed by: Dan Cross <cross@oxidecomputer.com>
    Reviewed by: Bill Sommerfeld <sommerfeld@hamachi.org>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF