Project

General

Profile

Actions

Bug #16257

closed

bnu: parameters default to int

Added by Toomas Soome 12 days ago. Updated 7 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

Multiple build errors with modern options - missing int type specifier.

Testing done: the wsdiff is reporting some diffs in constants like this (full report is attached):

NOTE: ELF .text difference detected.

1193c1193
<     getsysline+0x7a:  68 e1 01 00 00     pushl  $0x1e1
---
>     getsysline+0x7a:  68 e0 01 00 00     pushl  $0x1e0


Files

report.txt (1.62 MB) report.txt Toomas Soome, 2024-02-14 09:13 AM
Actions #1

Updated by Electric Monk 12 days ago

  • Gerrit CR set to 3274
Actions #2

Updated by Toomas Soome 8 days ago

Actions #3

Updated by Electric Monk 7 days ago

  • Status changed from Pending RTI to Closed
  • % Done changed from 90 to 100

git commit 3b296559ccf4430268fec1fbbb543f59c9a7113b

commit  3b296559ccf4430268fec1fbbb543f59c9a7113b
Author: Toomas Soome <tsoome@me.com>
Date:   2024-02-14T22:00:16.000Z

    16257 bnu: parameters default to int
    Reviewed by: Dan Cross <cross@oxidecomputer.com>
    Reviewed by: Bill Sommerfeld <sommerfeld@hamachi.org>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF