Project

General

Profile

Actions

Bug #16258

closed

telnet: parameter defaults to 'int'

Added by Toomas Soome 14 days ago. Updated 13 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

Build errors with modern options:

    sys_bsd.c: In function 'process_rings':
    sys_bsd.c:750:1: error: type of 'netin' defaults to 'int' [-Werror=implicit-int]
      750 | process_rings(netin, netout, netex, ttyin, ttyout, poll)
          | ^~~~~~~~~~~~~
    sys_bsd.c:750:1: error: type of 'netout' defaults to 'int' [-Werror=implicit-int]
    sys_bsd.c:750:1: error: type of 'netex' defaults to 'int' [-Werror=implicit-int]
    sys_bsd.c:750:1: error: type of 'ttyin' defaults to 'int' [-Werror=implicit-int]
    sys_bsd.c:750:1: error: type of 'ttyout' defaults to 'int' [-Werror=implicit-int]
    cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk 14 days ago

  • Gerrit CR set to 3275
Actions #2

Updated by Toomas Soome 13 days ago

  • Status changed from In Progress to Pending RTI

Testing done: wsdiff does not report binary differences.

Actions #3

Updated by Electric Monk 13 days ago

  • Status changed from Pending RTI to Closed
  • % Done changed from 90 to 100

git commit 905213bbae11fe989ca214e71ef9a970b403ea0e

commit  905213bbae11fe989ca214e71ef9a970b403ea0e
Author: Toomas Soome <tsoome@me.com>
Date:   2024-02-10T16:53:21.000Z

    16258 telnet: parameter defaults to 'int'
    Reviewed by: Jason King <jason.brian.king+illumos@gmail.com>
    Reviewed by: Dan Cross <cross@oxidecomputer.com>
    Reviewed by: Bill Sommerfeld <sommerfeld@hamachi.org>
    Approved by: Dan McDonald <danmcd@mnx.io>

Actions

Also available in: Atom PDF