Project

General

Profile

Actions

Bug #16261

closed

oawk: parameters default to int

Added by Toomas Soome 12 days ago. Updated 6 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

Build errors with modern options. Bring oawk into just a bit better shape, so the eyes wont bleed...

Add 'int' where needed, use vfprintf().

Testing done: wsdiff does report binary differences in:
parse.o : ELF .shstrtab
oawk : ELF .text
lib.o : ELF .text (error() change + constants diff in getrec()).


Files

report.txt (240 KB) report.txt Toomas Soome, 2024-02-14 02:12 PM
Actions #1

Updated by Electric Monk 12 days ago

  • Gerrit CR set to 3278
Actions #2

Updated by Toomas Soome 8 days ago

Actions #3

Updated by Toomas Soome 6 days ago

Toomas Soome wrote:

Build errors with modern options. Bring oawk into just a bit better shape, so the eyes wont bleed...

Add 'int' where needed, use vfprintf().

Testing done: wsdiff does report binary differences in:
parse.o : ELF .shstrtab
oawk : ELF .text
lib.o : ELF .text (error() change + constants diff in getrec()).

also some simple error cases:

tsoome@beastie:/code/16261/usr/src/cmd/oawk$ ls -l |./oawk -f 
awk: no argument for -f
tsoome@beastie:/code/16261/usr/src/cmd/oawk$ ls -l |./oawk '{print $-1}'
awk: trying to access field -1
 record number 1
tsoome@beastie:/code/16261/usr/src/cmd/oawk$

Actions #4

Updated by Electric Monk 6 days ago

  • Status changed from Pending RTI to Closed
  • % Done changed from 90 to 100

git commit 4774dff6a15e3052e75fd8a0fdd519521be2db59

commit  4774dff6a15e3052e75fd8a0fdd519521be2db59
Author: Toomas Soome <tsoome@me.com>
Date:   2024-02-15T22:56:47.000Z

    16261 oawk: parameters default to int
    Reviewed by: Andy Fiddaman <illumos@fiddaman.net>
    Reviewed by: Dan Cross <cross@oxidecomputer.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF