Project

General

Profile

Actions

Bug #16264

closed

spray: 'usecs' defaults to 'int'

Added by Toomas Soome 12 days ago. Updated 7 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

Build errors with modern options:

    spray.c: In function 'slp':
    spray.c:168:1: error: type of 'usecs' defaults to 'int' [-Werror=implicit-int]
     slp(usecs)
     ^~~
    cc1: all warnings being treated as errors

Testing done: wsdiff does not show binary difference

tsoome@omnios:/code/16264$ grep NOTE: report.txt 
NOTE: ASCII difference detected.
NOTE: ASCII difference detected.
NOTE: ASCII difference detected.
tsoome@omnios:/code/16264$
Actions #1

Updated by Electric Monk 12 days ago

  • Gerrit CR set to 3280
Actions #2

Updated by Toomas Soome 8 days ago

  • Description updated (diff)
Actions #3

Updated by Toomas Soome 8 days ago

  • Status changed from In Progress to Pending RTI
Actions #4

Updated by Electric Monk 7 days ago

  • Status changed from Pending RTI to Closed
  • % Done changed from 90 to 100

git commit 201ceb75ab95f9bf1f42ea1dc9ab363b43ba47cf

commit  201ceb75ab95f9bf1f42ea1dc9ab363b43ba47cf
Author: Toomas Soome <tsoome@me.com>
Date:   2024-02-14T21:47:45.000Z

    16264 spray: 'usecs' defaults to 'int'
    Reviewed by: Peter Tribble <peter.tribble@gmail.com>
    Reviewed by: Dan Cross <cross@oxidecomputer.com>
    Reviewed by: Bill Sommerfeld <sommerfeld@hamachi.org>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF