Project

General

Profile

Actions

Bug #16407

closed

Raphael DF revision detection is incorrect

Added by Robert Mustacchi 2 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

The amdzen DF feature detection has a logic bug of sorts. Right now it identifies things as being DFv4 if the version is explicitly v4.0. While there are many more revisions and related, Raphael reports as v4.1 and Phoenix as v4.2. This causes them to fail to properly identify the revision. When in tandem with #16404 that leads to more confusion and disappointment. In tandem with #16405 this clean this all up and makes sure that we're good through most known and upcoming DF revisions.

Actions #1

Updated by Electric Monk 2 months ago

  • Gerrit CR set to 3378
Actions #2

Updated by Robert Mustacchi about 2 months ago

With fixed bits, this now shows the right DF revision and attempting to use the udf development tool works:

raphael # psrinfo -vp
The physical processor has 6 cores and 12 virtual processors (0-11)
  The core has 2 virtual processors (0 6)
  The core has 2 virtual processors (1 7)
  The core has 2 virtual processors (2 8)
  The core has 2 virtual processors (3 9)
  The core has 2 virtual processors (4 10)
  The core has 2 virtual processors (5 11)
    x86 (AuthenticAMD A60F12 family 25 model 97 step 2 clock 4700 MHz)
      AMD Ryzen 5 7600X 6-Core Processor        [ Socket: AM5 ]
raphael # mdb -k
Loading modules: [ unix genunix specfs dtrace mac cpu.generic uppc apix scsi_vhci zfs sata ip hook neti sockfs arp usba xhci smbios stmf stmf_sbd mm lofs vmm crypto random cpc ufs logindmux nsmb ptm smbsrv klmmod nfs ]
> *amdzen_data::print amdzen_t azn_dfs[0].adf_rev
azn_dfs[0].adf_rev = 0x8 (DF_REV_4)
raphael # /usr/lib/udf -d /devices/pseudo/amdzen@0/zen_udf@3:zen_udf.0 -f 0 -i 4 -r 0x44
ifr 4/0/44: 0x1111260
raphael # /usr/lib/udf -d /devices/pseudo/amdzen@0/zen_udf@3:zen_udf.0 -f 0 -i 0 -r 0x44
ifr 0/0/44: 0x1911264
Actions #3

Updated by Electric Monk about 2 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 019df03d95e2a1cb86c73dd53255176f9611836a

commit  019df03d95e2a1cb86c73dd53255176f9611836a
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2024-04-08T21:42:53.000Z

    16407 Raphael DF revision detection is incorrect
    16405 initial amdzen family 1ah and cpuid support
    16406 zen topo should tolerate missing revision or ppin info
    Reviewed by: Andy Fiddaman <illumos@fiddaman.net>
    Reviewed by: Luqman Aden <luqman@oxide.computer>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions

Also available in: Atom PDF