Project

General

Profile

Actions

Bug #16434

closed

kernel modules should use consistent relative source paths

Added by Rich Lowe 21 days ago. Updated 18 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
kernel
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

A future change I have in the pipeline which a few folks have looked at is easier to integrate and reason about if kernel modules already use a consistent, relative, source path.

That is

UTSBASE = ../..

rather than

UTSBASE = $(SRC)/uts

or other variants. The goal is for it to be the briefest, non-absolute, path (so that the workspace path etc, don't get into objects and further make wsdiff a bit hairy)

Actions #1

Updated by Rich Lowe 21 days ago

testing:

wsdiff reveals changes to the rodata string sections (paths in assertions, etc, changing, the whole goal of this change).
and relocation offsets changing because of same.

; wsdiff -uvVr paths.log old-proto/root_i386 proto/root_i386                                                                                                 
etc/motd                                                                                                                                                     
kernel/drv/amd64/tpm                                                          
kernel/drv/amd64/smartpqi                                    
kernel/drv/amd64/pvscsi                                                       
kernel/drv/amd64/pmcs                                                         
kernel/drv/amd64/mpt_sas                                                                                                                                     
kernel/drv/amd64/lmrc        
Actions #2

Updated by Electric Monk 21 days ago

  • Gerrit CR set to 3391
Actions #3

Updated by Electric Monk 18 days ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit d363b1b0cb9ef6d6f3febdd8d1cba46507e97098

commit  d363b1b0cb9ef6d6f3febdd8d1cba46507e97098
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2024-04-02T20:29:26.000Z

    16434 kernel modules should use consistent relative source paths
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Peter Tribble <peter.tribble@gmail.com>
    Reviewed by: Bill Sommerfeld <sommerfeld@hamachi.org>
    Approved by: Patrick Mooney <pmooney@pfmooney.com>

Actions

Also available in: Atom PDF