Project

General

Profile

Actions

Bug #16530

closed

cmd/audio should deal in big-endian and little-endian, not sparc and i386

Added by Rich Lowe 21 days ago. Updated 9 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

The audio code in cmd/audio deals with endianness in terms of platforms known to be that endian, rather than just using the endian constants. It should use the endian constants.

Actions #1

Updated by Rich Lowe 21 days ago

testing:
- No change to resulting binaries on i386
- audioconvert(1) still works as far as file(1) can determine (I lack audio hardware)

Actions #2

Updated by Electric Monk 21 days ago

  • Gerrit CR set to 3458
Actions #3

Updated by Electric Monk 9 days ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 3b363e384673bd88fc57814d909651859c7c41a3

commit  3b363e384673bd88fc57814d909651859c7c41a3
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2024-05-17T21:43:29.000Z

    16530 cmd/audio should deal in big-endian and little-endian, not sparc and i386
    Reviewed by: Jason King <jason.brian.king+illumos@gmail.com>
    Reviewed by: Bill Sommerfeld <sommerfeld@hamachi.org>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Peter Tribble <peter.tribble@gmail.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF