Project

General

Profile

Actions

Bug #16531

closed

clean up low-hanging warnings in cmd/audio

Added by Rich Lowe 21 days ago. Updated 9 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

There's a handful of warnings in cmd/audio which are trivial to stomp:

- Unused variables (remove them)
- Reordered C++ initialization (order them to match the declaration)
- Parenthesis (add braces to dangling else, parens in assignment in conditional)
- Return type (we were trying to return char *const the qualifier of which is ignored)

While here, we can also remove the lint and ranlib parts of the makefile (ranlib being a no-op since SunOS 5.0)

Actions #1

Updated by Rich Lowe 21 days ago

testing:
- No change to resulting binaries on i386
- audioconvert(1) still works as far as file(1) can determine (I lack audio hardware)

Actions #2

Updated by Electric Monk 20 days ago

  • Gerrit CR set to 3459
Actions #3

Updated by Electric Monk 9 days ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit d8048045f75b60d97deaf376b39d437b027becd1

commit  d8048045f75b60d97deaf376b39d437b027becd1
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2024-05-17T22:02:26.000Z

    16531 clean up low-hanging warnings in cmd/audio
    Reviewed by: Jason King <jason.brian.king+illumos@gmail.com>
    Reviewed by: Bill Sommerfeld <sommerfeld@hamachi.org>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Peter Tribble <peter.tribble@gmail.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF