Bug #1655
ata erroneously treats inq_qual as DPQ
Status:
New
Priority:
Normal
Assignee:
-
Category:
driver - device drivers
Start date:
2011-10-15
Due date:
% Done:
0%
Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Description
in struct scsi_inquiry, the SCSI "Peripheral Device Qualifier", embodied in the DPQ_* macros, is actually part of the compound inq_dtype field. inq_qual is the SCSI-1 "Device Type Modifier"
ata(7D) contains code which does this:
2693 inqp->inq_dtype = DTYPE_DIRECT; 2694 inqp->inq_qual = DPQ_POSSIBLE;
Likely intending to actually DTYPE_DIRECT|DPQ_POSSIBLE, while leaving inq_qual as 0.
I came across his while fixing #1654, by inspection, and have not tested this in the least. People fixing this should refer to SPC-3 6.4.2
Related issues