Project

General

Profile

Actions

Bug #16557

closed

umem_setmtbf() misses vmem_mtbf

Added by Robert Mustacchi 14 days ago. Updated 1 day ago.

Status:
Closed
Priority:
Normal
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

When I added a means to set the umem mtbf at run time in #12359 that missed that there was a separate vmem tunable. For most users of this they want to be set to the same, so I've gone ahead and made it so both are dealt with as the most common use is testing and most callers are using this to cause all allocations to fail. This matches what the manual page says and as its an uncommitted interface we can change this or separate them out later if needed.

This has been tested alongside #16545 as the updated memalign based calls were not failing because they were considered oversize and going into vmem. With this, they now pass and memory failures are occurring as expected.

Actions #1

Updated by Electric Monk 14 days ago

  • Gerrit CR set to 3476
Actions #2

Updated by Electric Monk 1 day ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 3448eae2e9d99e7fadeb43056eb8e788c7ea93be

commit  3448eae2e9d99e7fadeb43056eb8e788c7ea93be
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2024-05-24T16:28:43.000Z

    16545 aligned_alloc not conformant with C11 standard
    16557 umem_setmtbf() misses vmem_mtbf
    Reviewed by: Gordon Ross <Gordon.W.Ross@gmail.com>
    Reviewed by: Andy Fiddaman <illumos@fiddaman.net>
    Reviewed by: Bill Sommerfeld <sommerfeld@hamachi.org>
    Approved by: Patrick Mooney <pmooney@pfmooney.com>

Actions

Also available in: Atom PDF