Project

General

Profile

Actions

Bug #16567

closed

clean up yacc grammar

Added by Toomas Soome 30 days ago. Updated 4 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

While testing .y code with bison, I was receiving errors and found some old constructs. I used https://pubs.opengroup.org/onlinepubs/9699919799/utilities/yacc.html as reference and did a bit of cleaning up, removed commas from token definitions and fixed = { action constructs.


Related issues

Related to illumos gate - Bug #16319: tools: add yacc to build toolsIn ProgressToomas Soome

Actions
Actions #1

Updated by Electric Monk 30 days ago

  • Gerrit CR set to 3486
Actions #2

Updated by Toomas Soome 30 days ago

  • Related to Bug #16319: tools: add yacc to build tools added
Actions #3

Updated by Toomas Soome 5 days ago

  • Status changed from In Progress to Pending RTI

Testing done:
I did compare builds of master and 16567+16319 with wsdiff over proto trees:

tsoome@balrog:/code/illumos-gate$ wsdiff -vr report.txt proto ../yacc/proto
ERROR: diff_ctf: Could not find genunix. CTF diffs will be less useful.
etc/versions/build
etc/motd
usr/bin/truss
usr/sbin/iasl
usr/sbin/acpixtract
usr/sbin/acpidump
platform/i86xpv/kernel/amd64/unix
platform/i86pc/kernel/amd64/unix
tsoome@balrog:/code/illumos-gate$

The diffs reported are about branch name difference - I forgot to switch off the mechanism to store git branch name in build information. So, indeed, there appears to be no impact on generated binaries.

Actions #4

Updated by Electric Monk 4 days ago

  • Status changed from Pending RTI to Closed
  • % Done changed from 80 to 100

git commit 724c5febb0bca8c78130986f24885a869b87d7b6

commit  724c5febb0bca8c78130986f24885a869b87d7b6
Author: Toomas Soome <tsoome@me.com>
Date:   2024-06-11T20:53:42.000Z

    16567 clean up yacc grammar
    Reviewed by: Andy Fiddaman <illumos@fiddaman.net>
    Reviewed by: Bill Sommerfeld <sommerfeld@hamachi.org>
    Approved by: Patrick Mooney <pmooney@pfmooney.com>

Actions

Also available in: Atom PDF